Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix typo preventing test from running #31931

Merged
merged 2 commits into from
Feb 26, 2020
Merged

test: fix typo preventing test from running #31931

merged 2 commits into from
Feb 26, 2020

Conversation

Trott
Copy link
Member

@Trott Trott commented Feb 24, 2020

test-fs-watch-system-limit is always being skipped because of a typo.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Feb 24, 2020
@Trott
Copy link
Member Author

Trott commented Feb 24, 2020

Pummel CI: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/12391/

@lundibundi
Copy link
Member

@Trott Actually, after checking through tests it looks like we only ever use enoughTestCpu 😄.
We should probably just change this in common/index.js to enoughTestCpu.

@lundibundi lundibundi mentioned this pull request Feb 24, 2020
Closed
2 tasks
@Trott
Copy link
Member Author

Trott commented Feb 24, 2020

@Trott Actually, after checking through tests it looks like we only ever use enoughTestCpu 😄.
We should probably just change this in common/index.js to enoughTestCpu.

Oh, goodness, it's even enoughTestCpu in the .mjs version of common. Yeah, let's do the ergonomic thing and change it in common/index.js instead.

@Trott
Copy link
Member Author

Trott commented Feb 24, 2020

Also, enoughTestCpu is not documented in the README.

@Trott
Copy link
Member Author

Trott commented Feb 24, 2020

Also, enoughTestCpu is not documented in the README.

Now it is (in this PR).

@Trott
Copy link
Member Author

Trott commented Feb 24, 2020

Re-running pummel CI: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/12396/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29311/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29337/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29343/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29356/

addaleax
addaleax reviewed Feb 26, 2020
View reviewed changes
test/common/README.md Outdated Show resolved Hide resolved
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29383/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29389/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29390/

@Trott
test: fix typo in common/index.js
fc68bf2 
All tests using enoughTestCpu checks are always having the checks come
back false due to a typo in common/index.js. Fix the typo.

PR-URL: nodejs#31931
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@Trott
test: add documentation for common.enoughTestCpu
8824229 
PR-URL: nodejs#31931
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@Trott
Copy link
Member Author

Trott commented Feb 26, 2020

Landed in 54eb7e6...8824229

@Trott Trott merged commit 8824229 into nodejs:master Feb 26, 2020
@Trott Trott deleted the intense branch February 26, 2020 20:48
codebytere pushed a commit that referenced this pull request Feb 27, 2020
@Trott @codebytere
test: fix typo in common/index.js
918c2b6 
All tests using enoughTestCpu checks are always having the checks come
back false due to a typo in common/index.js. Fix the typo.

PR-URL: #31931
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
codebytere pushed a commit that referenced this pull request Feb 27, 2020
@Trott @codebytere
test: add documentation for common.enoughTestCpu
04eda02 
PR-URL: #31931
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@codebytere codebytere mentioned this pull request Feb 29, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 15, 2020
@Trott @codebytere
test: fix typo in common/index.js
618823a 
All tests using enoughTestCpu checks are always having the checks come
back false due to a typo in common/index.js. Fix the typo.

PR-URL: #31931
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
codebytere pushed a commit that referenced this pull request Mar 15, 2020
@Trott @codebytere
test: add documentation for common.enoughTestCpu
83a67ec 
PR-URL: #31931
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
@Trott @codebytere
test: fix typo in common/index.js
9d70107 
All tests using enoughTestCpu checks are always having the checks come
back false due to a typo in common/index.js. Fix the typo.

PR-URL: #31931
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
@Trott @codebytere
test: add documentation for common.enoughTestCpu
8c81d05 
PR-URL: #31931
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@codebytere codebytere mentioned this pull request Mar 17, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 30, 2020
@Trott @codebytere
test: fix typo in common/index.js
0c6fdfc 
All tests using enoughTestCpu checks are always having the checks come
back false due to a typo in common/index.js. Fix the typo.

PR-URL: #31931
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
codebytere pushed a commit that referenced this pull request Mar 30, 2020
@Trott @codebytere
test: add documentation for common.enoughTestCpu
c2ffef8 
PR-URL: #31931
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@ZYSzys ZYSzys ZYSzys approved these changes

@lundibundi lundibundi lundibundi approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@awibox awibox awibox approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Trott @lundibundi @nodejs-github-bot @addaleax @lpinca @awibox @BridgeAR @ZYSzys